594732 - Broken statusbar: unread and total messages labels are on left. Other informations are missing (e.g. offline indicator)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[u382332]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b6pre) Gecko/20100908 Firefox/4.0b6pre
Build Identifier: 

Statusbar is broken.

Screenshot:
http://img20.imageshack.us/content_round.php?page=done&l=img20/8703/tbirdbustedstatusbar.png

Reproducible: Always

Comment 1

[u382332]

ooops...Direct link to screenshot.

http://img20.imageshack.us/img20/8703/tbirdbustedstatusbar.png

Comment 2

[u382332]

Regression range.

Works:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b6pre) Gecko/20100907 Thunderbird/3.2a1pre

Broken:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b6pre) Gecko/20100908 Thunderbird/3.2a1pre

Comment 3

[Nomis101]

I can confirm this for Mac OS X. Mail count is now on the left site. Status text, progressbar and icon (online/offline) is missing. I see nothing in the error console and my debug build doesn't give any usefull information for this.

Comment 4

[[:Aureliano Buendía]]

Attachment: bug in action

Confirmed also here from yesterday nightly build

Mozilla/5.0 (Windows NT 6.1; rv:2.0b6pre) Gecko/20100909 Thunderbird/3.2a1pre ID:20100909031945

Comment 5

[[:Aureliano Buendía]]

pushlog:

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2010-09-07&enddate=2010-09-08

could be bug #579672?

Comment 6

[Nomis101]

(In reply to comment #5)
> pushlog:
> 
> http://hg.mozilla.org/comm-central/pushloghtml?startdate=2010-09-07&enddate=2010-09-08
> 
> could be bug #579672?
This was also my candidate, so I've backed this patch out today, but with this build I still see this issue. So I think its a regression from m-c.

Comment 7

[Nomis101]

(In reply to comment #6)
> (In reply to comment #5)
> > pushlog:
> > 
> > http://hg.mozilla.org/comm-central/pushloghtml?startdate=2010-09-07&enddate=2010-09-08
> > 
> > could be bug #579672?
> This was also my candidate, so I've backed this patch out today, but with this
> build I still see this issue. So I think its a regression from m-c.

Oh, I revoke this comment. It seems I made something wrong if I backed this out yesterday. *oops*
I've tried it once again just now and it fixed this issue. So yes, its definitely a regression from bug #579672. Sorry for my false post...

Comment 8

[Nomis101]

Its only one removed line which causeed this. If I re-add this line, than its back to normal:

> }
>
>-loadSelectionSummaryStrings();
>-
> // Ah, wouldn't it be nice if there was platform code to do the following...
> 
> /**
>@@ -137,6 +139,9 @@ function _mm_removeClass(node, classname


I can switch the issue on and off, by removing (like in the patch) and re-adding this single line.

Comment 9

[Mark Banner (:standard8)]

Switching that line back on will regress bug 579672. I'll be taking a look into this next week.

Comment 12

[Joe Sabash [:JoeS1]]

Nominating for blocker status as this has security implications ... links are no longer visible in the status bar.
Click at your own risk, who knows where that will take you.

Comment 13

[Mark Banner (:standard8)]

This is already a blocker - see blocking-thunderbird-next+

Comment 14

[Mark Banner (:standard8)]

Attachment: The fix

Just like in bug 579672 we're touching the DOM before completing window load, this delays this action until we actually require it.

Note to self: for future issues like this, stick a debugger; statement in LightweightThemeConsumer's initialiser and check what's calling it on the stack - if it is just general.xml then we're probably fine.

Comment 15

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/546f9e45898a

Comment 16

[u382332]

Confirmed fixed. Thanks Mark.

Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100928 Thunderbird/3.3a1pre

Comment 17

[Russ Hansen]

Thanks Mark. The attachment does not seem to fix the problem in the 3.1.x branch (assuming I committed it properly to the build), but at least you're good for 3.3. As much as I'd like to see this fixed in the current stable build, it hardly seems worth it.