594816 - Add a built-in system for badge handlers

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Now that we have a badging system in the Awesomescreen, we can add a few built-in handlers. This patch adds the foundation and a handler for gmail.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Notes:
* We use any saved username & password for gmail
* Also works if just logged into gamil, but have not saved the username and password
* Caches the count to reduce the XHR load

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 473602 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+
>+  register: function(aPopup) {
>+    for (let i = 0; i < this._handlers.length; i++)
>+      aPopup.registerBadgeHandler(this._handlers[i].url, this._handlers[i]);
>+  }

let handlers = this._handlers;


I wonder if we want a more elaborate text like "50 new mails" since you can also have a notification about instant messaging from gmail (like what an App Tab does by looking at the title)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with change:
http://hg.mozilla.org/mobile-browser/rev/afa447a64bdf

Comment 4

[Aaron Train [:aaronmt]]

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12892

Comment 5

[Dão Gottwald [:dao]]

bugspam

Comment 6

[Catalin Suciu [:csuciu]]

Verified as fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110914
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2