Closed Bug 594816 Opened 9 years ago Closed 9 years ago

Add a built-in system for badge handlers

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Now that we have a badging system in the Awesomescreen, we can add a few built-in handlers. This patch adds the foundation and a handler for gmail.
Attachment #473602 - Flags: review?(21)
Notes:
* We use any saved username & password for gmail
* Also works if just logged into gamil, but have not saved the username and password
* Caches the count to reduce the XHR load
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 473602 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+
>+  register: function(aPopup) {
>+    for (let i = 0; i < this._handlers.length; i++)
>+      aPopup.registerBadgeHandler(this._handlers[i].url, this._handlers[i]);
>+  }

let handlers = this._handlers;


I wonder if we want a more elaborate text like "50 new mails" since you can also have a notification about instant messaging from gmail (like what an App Tab does by looking at the title)
Attachment #473602 - Flags: review?(21) → review+
pushed with change:
http://hg.mozilla.org/mobile-browser/rev/afa447a64bdf
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Flags: in-litmus?
bugspam
Assignee: nobody → mark.finkle
Verified as fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110914
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.