594881 - XUL windows restore size mode after setting position and size

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Jim Mathies [:jimm]]

Spin off from bug 574638. There's a patch over there that addresses this, but it needs more testing. In nsXULWindow's OnChromeLoaded, we set the position and size of the window and then restore a persisted size mode. With the removal of child widgets this causes an issue where the window is displayed before restoring to the maximized state. This is due to the resize, which triggers a size event that ends up triggering a call to Show in nsDocumentViewer.

Comment 1

[Alice0775 White]

It happens on Window XP, Windows 7 Classic and Aero Basic.
However on Windows 7 Aero, I do not attract attention.

if you set "Animate windows when minimizing or maximizing", the problem become more terrible.

1. Open Control panel
2. In the performance section
3. Check "Animate windows when minimizing or maximizing".

Comment 2

[Dietrich Ayala (:dietrich)]

Blocking+ for janky UI, and because it blocks a blocker.

Comment 3

[[not reading bugmail]]

(In reply to comment #1)
> if you set "Animate windows when minimizing or maximizing", the problem become
> more terrible.
> 
> 1. Open Control panel
> 2. In the performance section
> 3. Check "Animate windows when minimizing or maximizing".

This is usually on by default.

Comment 4

[[not reading bugmail]]

Jim this is still a problem using the most recent hourly.  I still see the window paint 3 times resizing going from normal to maximized.  

Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101015 Firefox/4.0b8pre ID:20101015 142332

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #4)
> Jim this is still a problem using the most recent hourly.  I still see the
> window paint 3 times resizing going from normal to maximized.  
> 
> Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101015 Firefox/4.0b8pre
> ID:20101015 142332

Hmm, I just don't see it.

aero basic desktop

1) open fx, maximize
2) ctrl-n

new window opens on top of the old one.

Can you try temporarily disabling any add-ons?

Comment 6

[[not reading bugmail]]

I tried that. I think that's fixed.   Maybe I got thinking this bug would address https://bugzilla.mozilla.org/show_bug.cgi?id=574638#c61 with the obsolete patch over there.

1) open fx
2) be in normal mode
3) maximize
result: 
watch browser paint 3 times while resizing.

Comment 7

[Jim Mathies [:jimm]]

(In reply to comment #6)
> I tried that. I think that's fixed.   Maybe I got thinking this bug would
> address https://bugzilla.mozilla.org/show_bug.cgi?id=574638#c61 with the
> obsolete patch over there.
> 
> 1) open fx
> 2) be in normal mode
> 3) maximize
> result: 
> watch browser paint 3 times while resizing.

Hmm, different bug! Let's file a new one on that, that has to do with reflow/painting during window transitions.

Comment 8

[[not reading bugmail]]

(In reply to comment #7)
> (In reply to comment #6)
> > I tried that. I think that's fixed.   Maybe I got thinking this bug would
> > address https://bugzilla.mozilla.org/show_bug.cgi?id=574638#c61 with the
> > obsolete patch over there.
> > 
> > 1) open fx
> > 2) be in normal mode
> > 3) maximize
> > result: 
> > watch browser paint 3 times while resizing.
> 
> Hmm, different bug! Let's file a new one on that, that has to do with
> reflow/painting during window transitions.

Filed bug 604861 for this.

Comment 9

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336