594922 - Tab bar has no default height

Status: RESOLVED INCOMPLETE

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot

After the new tab look landed I noticed a few strange sizing issues, mostly regarding app tabs.

Turns out there are at least three problems here:

a) the tab bar does not seem to have a default min width. To test this, have at least one app tab, no normal tab and also remove the alltabs and tabcandy buttons from the right (as well as all other custom buttons if they exist). The result will not be nice, see the screenshot (bottom)

b) custom buttons (excluding alltabs but including tabcandy) make tabs higher. IMHO this should not be the case.

c) related to problem b): while normal tabs and the new tab button grow to the new size (after adding a button and thus enlarging the tab bar), the app tabs don't adapt to the new height (screenshot, top)

Comment 1

[Michael Monreal [:micmon]]

Additionaly, activating a persona on linux currently changes the tabbar height on linux IF some extra button (like tabcandy) is present. Without it, the size stays the same.

Comment 2

[Michael Monreal [:micmon]]

Bug #593690 fixes issues b an c but the main problem (a) is still valid. The mentioned persona issue does not belong here.

Comment 3

[Michael Monreal [:micmon]]

Just re-tested with latest nightly, still happening.

Comment 4

[Michael Monreal [:micmon]]

No longer relevant with Photon theme.