594926 - Malformed font leads to crash in Apple's libTrueTypeScaler [@tiny_malloc_from_free_list]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase

Table: b'maxp'
Number of replaced values: 2
Offset:  6/0x000006 Value: ['00', '00', '00', '00', '00', '00', '00', '01']
Offset: 21/0x000015 Value: ['80', '00']

Execute the provided html file.

Comment 1

[Christoph Diehl [:posidron]]

Attachment: callstack

Comment 2

[Christoph Diehl [:posidron]]

  <maxp>
    <tableVersion value="0x10000"/>
    <numGlyphs value="571"/>
    <maxPoints value="0"/>
    <maxContours value="0"/>
    <maxCompositePoints value="0"/>
    <maxCompositeContours value="1"/>
    <maxZones value="2"/>
    <maxTwilightPoints value="0"/>
    <maxStorage value="0"/>
    <maxFunctionDefs value="128"/>
    <maxInstructionDefs value="0"/>
    <maxStackElements value="512"/>
    <maxSizeOfInstructions value="777"/>
    <maxComponentElements value="2"/>
    <maxComponentDepth value="1"/>
  </maxp>

Comment 3

[Johnny Stenback (:jst)]

Per Joe these are likely exploitable on trunk with a slightly modified testcase, so marking that this applies to trunk as well.

Comment 4

[Christoph Diehl [:posidron]]

Attachment: testcase-trunk

Comment 5

[John Daggett (:jtd)]

(In reply to comment #4)
> Created attachment 478731 [details]
> testcase-trunk

I can't reproduce a crash against trunk on 10.6.5 10H542 with either harfbuzz enabled or disabled.  1.9.2 goes down easily.

Comment 6

[John Daggett (:jtd)]

No longer reproducible on 10.6.5 with either trunk or 1.9.2.latest:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13pre) Gecko/20101114 Namoroka/3.6.13pre

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101114 Firefox/4.0b8pre

Comment 7

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13pre) Gecko/20101117 Namoroka/3.6.13pre using testcase. Crash occurs with 1.9.2.12.

Comment 8

[Daniel Veditz [:dveditz]]

OTS landed in 1.9.1 as well.

Comment 9

[Daniel Veditz [:dveditz]]

Was this one of the bugs fixed in the latest Mac updates? Would like to un-hide the bug.

Comment 10

[Christoph Diehl [:posidron]]

Yes, the bug is fixed.