595003 - Clicking on download notification with awesome screen open moves user back to browser window

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100909 Namoroka/4.0b6pre Fennec/2.0b1pre

Steps to Reproduce:
1. Start a download
2. Click on the url bar to open the awesome screen
3. Slide open the notifications window 
4. Click on the "downloading notification"

Actual Results:
The user is moved to the browser window

Expected Results:
The user should be moved to the download manager

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

This is an order of operations problem. The activePanel setter calls BrowserUI.showToolbar(false); which calls hidePanel and undoes everything we did to show it.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477352 [details] [diff] [review]
Patch

Seems safe enough. I don't think we put the code in the middle on purpose to begin with.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/f2ec842f36f8

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre

Comment 6

[Ayan Shah[:ashah]]

Litmus test case - 

https://litmus.mozilla.org/show_test.cgi?id=12701