595037 - Panels width/height doesn't automatically change

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Hernán Rodriguez Colmeiro (:peregrino)]

Steps to reproduce:
1) create a panel
2) show it
3) try to change it's width or height

Expected behavior:
That the panel automatically changes to the new dimensions.

Seen behavior:
Nothing happens until you hide and show the panel again.

Reproducible:
Allways

Comment 1

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: WIP adds sizeTo for panels

Myk, I went the way you said about adding a sizeTo for the panels. I also added some tests.

What do you think?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 475124 [details] [diff] [review]
WIP adds sizeTo for panels

This looks great!  The only change I would make is to rename the public method to "resize", which seems a bit easier to comprehend (and easier to type) than the mixed-case "sizeTo" in the XUL API.

Comment 3

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: Adds resize method to panels

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 475696 [details] [diff] [review]
Adds resize method to panels

This code looks great!  Unfortunately, the code it is modifying has changed significantly in the last few days, such that this patch no longer applies.  Can you update it to apply to the new version of panel.js?  Also, this new public method should be documented in panel.md.

Comment 5

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: Adds resize method to panels V2

Rewritten the patch so that it can be applied to the new panel.js code. Also added documentation in docs/panel.md

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 477395 [details] [diff] [review]
Adds resize method to panels V2

>+Resizes the panel to its new dimentions.

Nit: dimentions -> dimensions

Otherwise, looks great! r=myk

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/2ae4a0b892c5.

Thanks for the fix!

Comment 8

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".