59505 - Include from xRemoteClient in nsAppRunner.cpp keeps QNX/Photon from compiling

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Jerry.Kirk]

QNX/Photon can't compile nsAppRunner.cpp becuase it tries 
to include nsXRemoteClientCID.h. Photon does not compile the
mozilla/widget/src/xremoteclient directory because it does not
use X. After talking with blizzard we think an autoconf setting
called "ENABLE_XREMOTE_SUPPORT" should be added which control this.

Comment 1

[cls]

Attachment: Add MOZ_ENABLE_XREMOTE to build

Comment 2

[Marcus Fellinger]

The changes in nsAppRunner.cpp are inconsistent. If nsIXRemoteClient.h is only
included if MOZ_ENABLE_XREMOTE, then it must also be used only in that case, and
not on all configurations defining XP_UNIX. Otherwise, compiling on QNX/Photon
will give another error, because now nsIXRemoteClient is an undefined
identifier.

Comment 3

[Marcus Fellinger]

Attachment: This patch changes the #ifdef XP_UNIX to #ifdef MOZ_ENABLE_XREMOTE for the declaration of HandleRemoteArguments, the call to HandleRemoteArguments, and the online-help about the -remote argument

Comment 4

[Christopher Blizzard (:blizzard)]

r=blizzard.  Just FYI, You should really use diff -u for patches.  Adding alecf
so that he can review this code since he's the module owner for this bit.

Comment 5

[Marcus Fellinger]

Attachment: New version of the patch using diff -u

Comment 6

[Marcus Fellinger]

Following to Christophers comment, I created a new version of the patch using
diff -u, and supplied it.

Comment 7

[Alec Flett]

looks fine..we're certain that MOZ_ENABLE_XREMOTE is on for (non-QNX) unix
builds by default?

Comment 8

[Christopher Blizzard (:blizzard)]

Yes, it's on by default:

autoconf.mk:MOZ_ENABLE_XREMOTE  = 1

Comment 9

[Christopher Blizzard (:blizzard)]

Checked in.

Comment 10

[Jon Granrose]

verified.