Incorrect errorCode comparison and enabled check in showUpdateError

RESOLVED FIXED in mozilla2.0b7

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Trunk
mozilla2.0b7
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

patch coming up... must have typo'd
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #473910 - Flags: review?(dtownsend)
Summary: Incorrect errorCode comparison in showUpdateError → Incorrect errorCode comparison and enabled check in showUpdateError
Comment on attachment 473910 [details] [diff] [review]
patch

noticed one other thing
Attachment #473910 - Attachment is obsolete: true
Attachment #473910 - Flags: review?(dtownsend)
Posted patch patch rev2Splinter Review
I'm surprised no one filed a bug about not getting update errors when update isn't auto
Attachment #473912 - Flags: review?(dtownsend)
Comment on attachment 473912 [details] [diff] [review]
patch rev2

Anyway to test this?
Attachment #473912 - Flags: review?(dtownsend) → review+
I've been trying to think of a decent way to. My current thought is checking for the alert being shown for a standard background update error. I'd like to get this in as is before the test though
Attachment #473912 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/1781513c9f9f
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
bah... I messed up on the removal of this._enabled. I thought it was for the general update service being enabled instead of not notifying about errors, etc. so I am reopening this. The good news is I was able to add a test.
Attachment #474582 - Flags: review?(dtownsend)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Filed bug 595722 to get _enabled renamed since it doesn't represent whether nsIUpdatePrompt is enabled or not.
Attachment #474582 - Flags: review?(dtownsend)
Attachment #474582 - Flags: review+
Attachment #474582 - Flags: approval2.0+
Followup pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/108be9954ccb
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.