595059 - Incorrect errorCode comparison and enabled check in showUpdateError

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

patch coming up... must have typo'd

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 473910 [details] [diff] [review]
patch

noticed one other thing

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

I'm surprised no one filed a bug about not getting update errors when update isn't auto

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 473912 [details] [diff] [review]
patch rev2

Anyway to test this?

Comment 5

[Robert Strong (they/them - no direct email)]

I've been trying to think of a decent way to. My current thought is checking for the alert being shown for a standard background update error. I'd like to get this in as is before the test though

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch - ready to import

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/1781513c9f9f

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch - followup with tests

bah... I messed up on the removal of this._enabled. I thought it was for the general update service being enabled instead of not notifying about errors, etc. so I am reopening this. The good news is I was able to add a test.

Comment 9

[Robert Strong (they/them - no direct email)]

Filed bug 595722 to get _enabled renamed since it doesn't represent whether nsIUpdatePrompt is enabled or not.

Comment 10

[Robert Strong (they/them - no direct email)]

Followup pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/108be9954ccb