595066 - Sync UI: Ask for email address instead of username

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

+++ This bug was initially created as a clone of Bug #589979 +++

Instead of having to enter both username and email address on sign-up, users should only be required to provide the email address.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Pretty much equivalent to Bug 589979 Part 3.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v2

Also update error messages mentioning user name (now mention email address
where appropriate).

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 474213 [details] [diff] [review]
v2

>+  onEmailChange: function () {
>+    //XXXzpao Not sure about this regex. Look into it in followup (bug 583650)
>+    let value = document.getElementById("weaveEmail").value;

this comment should die, and we should resolve that bug.  It's in the wrong place here, in any case.

>-        let error = Weave.Service.createAccount(username, password, email,
>+        let error = Weave.Service.createAccount(email, password, email,
>                                                 challenge, response);

Should we change the signature of createAccount?  as a followup, I think.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: v2.1

Address review comments

Comment 5

[Philipp von Weitershausen [:philikon]]

(In reply to comment #3)
> Should we change the signature of createAccount?  as a followup, I think.

I wasn't sure myself and left it like this for now, mostly also for backwards compat reasons. Filed bug 595879 as a followup.

Comment 6

[Philipp von Weitershausen [:philikon]]

Attachment: v3

Rebase on top of fixes from bug 596093.

Comment 7

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/9fe3efa02adf

Comment 8

[Kevin Brosnan]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100924 Firefox/4.0b7pre