595067 - values showed from datalist/list should be filtered by the field value by default and an attribute should disable that

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: WIP Patch

<datalist id='d'>
  <option>Foo</option>
  <option>Foobar</option>
</datalist>
<input list='d'>

The list should show "Foo" and "Foobar" if the user hasn't typed or has typed "F", "Fo", "Foo", "o" or "oo".

If mozNoFilter is set, the entire list will be shown.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Mounir Lamouri (:mounir)]

I hate doing that but I think it would be better to not try to write tests for that for the moment. We should push that for beta6 and tests can be written after. A lot of tests would have to be written for the list feature actually.

Gavin, do you think you can review this very small patch for Friday?

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 473930 [details] [diff] [review]
Patch v1

Jonas, let me know if that's what you were expecting.
Do you want me to add an IDL attribute? Doesn't sound really useful considering that is a temporary attribute which may disappear -someday- for a standardized one?

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 473930 [details] [diff] [review]
Patch v1

Why is this using regexp matching? That seems like it would result in strange behavior if the user types '.', '[', '\' or other characters that have special meaning in regexps. Why not simply do a substring search using something like:

if (filter && label.toLower().indexOf(lowerFieldValue) < 0) {
  continue;
}

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

Thanks, I didn't know indexOf ;)

Comment 6

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/fa6c83c1a10e

Comment 7

[Matthew N. [:MattN]]

mozNoFilter never got documented on MDN and so was almost re-implemented in bug 1349747. It also wasn't standardized as far as I can tell. I think it's an essential feature for @list to implement features such as Google search suggestions (which can include typo/spelling corrections) as described in some threads below.

Mentions in Google:
* https://www.w3.org/Bugs/Public/show_bug.cgi?id=9785
* https://lists.w3.org/Archives/Public/public-whatwg-archive/2011May/0050.html
* https://lists.w3.org/Archives/Public/public-html-comments/2012Oct/0000.html