Closed Bug 595139 Opened 10 years ago Closed 10 years ago

Use global VACUUM in Places

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b9
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fixed-in-places])

Attachments

(1 file, 2 obsolete files)

patch v1.1
24.82 KB, patch
Details | Diff | Splinter Review
Attached patch wip v1.0 (obsolete) — — Splinter Review 
Once we have global VACUUM component, we should replace our internal implementation.
Attached patch patch v1.0 (obsolete) — — Splinter Review 
on top of the r+sr patch for global vacuum.
Attachment #474017 - Attachment is obsolete: true
Attachment #482532 - Flags: review?(sdwilsh)
This should block the final release.  It does take care of a few edge cases that the current places code does not handle.
blocking2.0: --- → final+
Comment on attachment 482532 [details] [diff] [review]
patch v1.0

> // nsIDownloadHistory **********************************************************
While here, want to fix this one's style?

r=sdwilsh for pure awesome and code removal :)
Attachment #482532 - Flags: review?(sdwilsh) → review+
Whiteboard: [can land in places]
Attached patch patch v1.1 — — Splinter Review 
also removed the vacuum workaround in test_adaptive.js
Attachment #482532 - Attachment is obsolete: true
http://hg.mozilla.org/projects/places/rev/630a7a751079
Whiteboard: [can land in places] → [fixed-in-places]
http://hg.mozilla.org/mozilla-central/rev/630a7a751079
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
Was this backed out again ? I'm not seeing the changes in MXR at all*, even though I can see them in hg**. Is MXR still up-to-date ?

* http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp
** http://hg.mozilla.org/mozilla-central/log/ed37d1bcaea4/toolkit/components/places/src/nsNavHistory.cpp
mxr did not get the merge yet, from what I can tell. all places files are outdated.
(In reply to comment #7)
> Was this backed out again ? I'm not seeing the changes in MXR at all*, even
> though I can see them in hg**. Is MXR still up-to-date ?
mxr hasn't been updating.  This is being tracked in bug 620256.
You need to log in before you can comment on or make changes to this bug.