595149 - Javascript is executed on loading a javascript attachment

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect, P1)

Description

[Piotr Zalewa [:zalun]]

To reproduce:

1. create javascript file with .js extension
2. add as attachment
3 [review]. click to display - it will execute it and display

It can be used to create requests etc. - it will error if one would use this file as an attachment http://github.com/zalun/jsFiddleGithubDemo/blob/master/Demo/demo.js

Comment 1

[Daniel Buchner [:dbuc]]

Let's just make sure we aren't unintentionally attached js files any more...thinking this should go in this release.

Comment 2

[Piotr Zalewa [:zalun]]

Problem - it shouldn't eval the script with these setting:

https://github.com/zalun/FlightDeck/blob/master/apps/jetpack/media/js/Package.js#L61

Comment 3

[Piotr Zalewa [:zalun]]

I think it's not doing it - it's the display.

Comment 4

[Piotr Zalewa [:zalun]]

Unfortunately it shouldn't display it - here is the code responsible for it:
Preparing elements:
https://github.com/zalun/FlightDeck/blob/master/media/js/FlightDeck.Modal.js#L26
Displaying StickyWin:
https://github.com/zalun/FlightDeck/blob/master/media/js/Clientcide.ModalWindow.js

Comment 5

[Piotr Zalewa [:zalun]]

cancel the last one - it is happening in the Request

Comment 6

[Piotr Zalewa [:zalun]]

overloading processScripts fixes it
https://github.com/zalun/FlightDeck/commit/8d0fd640ce726105200d7c7335214675df32f405