595151 - remove the 'sentinels' and zero the protected function pointers too.

Status: RESOLVED DUPLICATE of bug 597881

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: remove the 'sentinels' and zero the protected function pointers too.

all is in the title.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 474027 [details] [diff] [review]
remove the 'sentinels' and zero the protected function pointers too.

mmm, multiple inheritance.. oh well, it's not virtual, so shouldn't make a difference.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Yes, this is the "easy" case of multiple inheritance: in addition to being non-virtual, the base classes don't have anything in common.

However if you want we can also make them be members, instead of base classes. The downside is that we would then have to manually define e.g. fDrawArrays as being equal to mPublicFunctions.fDrawArrays;

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

no no, it's fine as-is.