Closed Bug 595170 Opened 9 years ago Closed 9 years ago
Some single line inputs break the form filler tool
I loaded the enter bug page in Bugzilla and tried to tab through the form using the form filler buttons. When I got to the single line summary field the form filler took up most of the page.
(In reply to comment #4) > Created attachment 474545 [details] > Screen shot of the fennec error console Thanks for the screenshot and for the console dump. I suspect you have browser.formfill.enable set up to false in about:config? Mark, the only way to have null for this case seems to be to have this pref turn to false. The attached patch resolved the problem by checking "normal" before looking for a property on it.
(In reply to comment #5) > I suspect you have browser.formfill.enable set up to false in about:config? Correct, that explains why a new profile prevented the issue from showing.
Comment on attachment 474564 [details] [diff] [review] Patch Perhaps we should be checking the pref too and returning early, without doing any contact lookup.
(In reply to comment #7) > Comment on attachment 474564 [details] [diff] [review] > Patch > > Perhaps we should be checking the pref too and returning early, without doing > any contact lookup. Obviously you're right, there is no need for this unuseful work in this case.
The patch does what Mark suggests.
Comment on attachment 474641 [details] [diff] [review] Patch v0.2 Put the check above the LOG statement. I think that makes more sense.
Attachment #474641 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on build: Mozilla/5.0 (maemol Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.