595193 - Remove unnecessary zero new notification indicator on badges

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Zero new notification indicator

Mozilla/5.0 (Android; Linux armv7l; rv:2.0b6pre) Gecko/20100910 Firefox/4.0b6pre Fennec/2.0b1pre

Until there is an actual notification, a badge will present itself on the Awesome-Screen with a [0] new notification indicator. See screenshot.

This should be removed and only display a badge when there is an actual indicator.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch cleans up the code a bit, makes some helpers so we don't duplicate too much code in the handlers, and ignores "[0]" badges.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 474086 [details] [diff] [review]
patch

>+
>+  setNumberBadge: function(aItem, aValue) {
>+    if (parseInt(aValue) != 0) {
>+      aValue = BadgeHandlers.clampBadge(aValue);

You could probably use "this" instead of BadgeHandlers

>+      aItem.setAttribute("badge", aValue);
>+    } else {
>+      aItem.removeAttribute("badge");
>+    }

As seen on IRC I still think we need to wrap the item but this is an other bug.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/7dd8739c0d54

Comment 4

[Cristian Nicolae (:xti)]

This issue doesn't occur anymore on the latest Nightly build.

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110914
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2