Closed Bug 595198 Opened 14 years ago Closed 14 years ago

Web Console filter should not be case sensitive

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 -)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- -

People

(Reporter: msucan, Assigned: rcampbell)

References

Details

(Whiteboard: [Web-Console-Testday])

Attachments

(1 file)

[checked-in] Filter search case insensitive
2.31 KB, patch
dietrich
: review+
johnath
: approval2.0+
Details | Diff | Splinter Review 
Currently the filter finds only exact matches, which is far too strict, in terms of English searches. We are not searching for JavaScript code, or stuff like that. We are searching through human-readable output, hence I believe we should not be case-sensitive about.
I agree that case insensitivity would be better.
Blocks: devtools4b8
taking, despite lack of blocking status.
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
requesting blocking for B7.
blocking2.0: --- → ?
Comment on attachment 474759 [details] [diff] [review]
[checked-in] Filter search case insensitive

have to use this strange translate() function as we don't seem to support the lower-case() xpath2.0 function.

See bug 398389.
Attachment #474759 - Flags: review? → review?(dietrich)
(In reply to comment #5)
> Comment on attachment 474759 [details] [diff] [review]
> Filter search case insensitive
> 
> have to use this strange translate() function as we don't seem to support the
> lower-case() xpath2.0 function.
> 
> See bug 398389.

Jonas says that lower-case() may be implementable. Fingers crossed!
Would be really nice to have, but I don't think it blocks
blocking2.0: ? → -
Attachment #474759 - Flags: review?(dietrich) → review+
Attachment #474759 - Flags: approval2.0?
probably not a blocker but would like approval for landing. Improves searching experience.
Comment on attachment 474759 [details] [diff] [review]
[checked-in] Filter search case insensitive

One line fix for improved usability with 8 lines of test? Okay!
Attachment #474759 - Flags: approval2.0? → approval2.0+
Comment on attachment 474759 [details] [diff] [review]
[checked-in] Filter search case insensitive

http://hg.mozilla.org/mozilla-central/rev/34f833a4b7d0
Attachment #474759 - Attachment description: Filter search case insensitive → [checked-in] Filter search case insensitive
(In reply to comment #10)
> Comment on attachment 474759 [details] [diff] [review]
> [checked-in] Filter search case insensitive
> 
> One line fix for improved usability with 8 lines of test? Okay!

aces! Thank you!
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Whiteboard: [Web-Console-Testday]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: