595228 - assert in search code; calling unbind without a function

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Ian Gilman [:iangilman]]

trace: tabview assert: Must provide a function
iQClass_unbind("keydown",null)@chrome://browser/content/tabview.js:709
switchToBeforeMode()@chrome://browser/content/tabview.js:7449
()@chrome://browser/content/tabview.js:7404
SearchEventHandlerClass()@chrome://browser/content/tabview.js:7377
@chrome://browser/content/tabview.js:7576

  // ----------
  // Function: switchToBeforeMode
  // Make sure the event handlers are appropriate for
  // the before-search mode. 
  switchToBeforeMode: function switchToBeforeMode() {
    var self = this;
    iQ(document).unbind("keydown", this.currentHandler);
    this.currentHandler = function(event) self.beforeSearchKeyHandler(event);
    iQ(document).keydown(self.currentHandler);
  },

Need to check currentHandler before unbinding.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Ian Gilman [:iangilman]]

Comment on attachment 474453 [details] [diff] [review]
v1

Looks great. Thanks for taking care of this.

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b836c7151fc6