Closed
Bug 595237
Opened 14 years ago
Closed 14 years ago
Remove the not needed anymore D2D, D3D and OpenGL test suites as they are enabled by default
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: armenzg, Assigned: armenzg)
References
Details
Attachments
(1 file, 1 obsolete file)
4.38 KB,
patch
|
coop
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
As per IRC conversation since D@D got enabled by default there is no point on running the separate D2D reftests. Correct me if this incorrect.
Assignee | ||
Comment 1•14 years ago
|
||
joe mentions that we can disable D3D as well.
Summary: Remove the reftest D2D test suite → Remove the reftest D2D and D3D tests suite
Assignee | ||
Updated•14 years ago
|
Blocks: wait_time_improv
Assignee | ||
Comment 2•14 years ago
|
||
I want to improve our wait times and to do this I have written the patches to remove these suites which are no longer needed.
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
Priority: P3 → P2
Summary: Remove the reftest D2D and D3D tests suite → Remove the not needed anymore D2D, D3D and OpenGL test suites as they are enabled by default
Assignee | ||
Comment 3•14 years ago
|
||
This patch does not affect in anyway the output of "python config.py". It just cleans things up and shows that our branches do not have the exact talos configuration (which I am not planning to solve on this patch). 1 file changed, 67 insertions(+), 187 deletions(-)
Attachment #481513 -
Flags: review?(coop)
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 481513 [details] [diff] [review] no-op cleanup patch I don't why I should mix the work of two different things. Moving to bug 602525.
Attachment #481513 -
Attachment is obsolete: true
Attachment #481513 -
Flags: review?(coop)
Assignee | ||
Comment 5•14 years ago
|
||
This patch removes the mentioned test suites as we don't need them anymore. The differences on using "python config.py" only shows the changes that I want.
Attachment #481516 -
Flags: review?(coop)
Updated•14 years ago
|
Attachment #481516 -
Flags: review?(coop) → review+
Updated•14 years ago
|
Flags: needs-reconfig?
Assignee | ||
Comment 6•14 years ago
|
||
If anyone gets to this bug after reading the notice that will shortly be sent out and need to read more details here they are: PLEASE READ ENTIRELY: * what?!#$!$ Are we removing the test suites for D2D, D3D and OpenGL? ** NO, WE ARE NOT. Currently the preferences for these technologies are ON by default and therefore they are already being run within the regular standard test suites * are you sure what you are talking? ** YES * are stakeholders aware of this? who do you have approval from? ** YES. The GFX folks. check who is CCed This will be disabled on *_Tuesday morning_* without the need of a downtime and will give us back a *lot* of CPU usage on the testing pools and therefore improve wait times. If you have understood what I have said "keep calm and carry on": http://www.flubu.com/images/LJ/keep_calm_carry_on.jpg otherwise follow this link: http://bit.ly/djVLq6
Flags: needs-reconfig? → needs-reconfig+
Comment 7•14 years ago
|
||
Comment on attachment 481516 [details] [diff] [review] remove opengl, d2d and d3d test suites http://hg.mozilla.org/build/buildbot-configs/rev/7c711f8c578c
Attachment #481516 -
Flags: checked-in+
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: needs-reconfig+
Resolution: --- → FIXED
Was disabling reftest-opengl on Linux intentional? That was the one case where it was still different, since OpenGL is not yet enabled on Linux. Have we given up on plans to enable it?
Comment 9•14 years ago
|
||
buildbotcustom/valid_builders.py needs updating for this change I think.
Assignee | ||
Comment 10•14 years ago
|
||
No, it was not intentional as I thought that OpenGL was enabled there too and I thought the only thing left to do is to fix bug 593874. I doubt I would be able to work on changing the screen resolution on Fedora machines before November as I have higher priority bugs.
Assignee | ||
Comment 11•14 years ago
|
||
Filed bug 604047 for OpenGL coverage on Linux.
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•