595269 - remotereftest.py assumes ./server.js instead of reftest/server.js

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in starting the webserver for remote reftests, we set the arguments to xpcshell assuming we are running from the script directory.

Instead, we need to use the SCRIPT_DIRECTORY variable and point to the appropriate paths.

here is the source:
http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/remotereftest.py#185

and instead of:
"-f", "./" + "reftest/components/httpd.js",
"-f", "./" + "server.js"]

we should have something similar to this:
"-f", os.path.join(SCRIPT_DIRECTORY, "reftest/components/httpd.js"),
"-f", os.path.join(SCRIPT_DIRECTORY, "server.js")]


of course there might be some corner cases to take care of, but we should assume we can run tests similar to this cli:
python reftest/remotereftest.py --deviceIP=...

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: fix reftest server path for remote testing (1.0)

patch which does what the bug proposes.  Tested in a few scenarios and this seems to do the trick.

Comment 2

[cmtalbert]

http://hg.mozilla.org/mozilla-central/rev/92d0663ca54c