remotereftest.py assumes ./server.js instead of reftest/server.js

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
9 months ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
in starting the webserver for remote reftests, we set the arguments to xpcshell assuming we are running from the script directory.

Instead, we need to use the SCRIPT_DIRECTORY variable and point to the appropriate paths.

here is the source:
http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/remotereftest.py#185

and instead of:
"-f", "./" + "reftest/components/httpd.js",
"-f", "./" + "server.js"]

we should have something similar to this:
"-f", os.path.join(SCRIPT_DIRECTORY, "reftest/components/httpd.js"),
"-f", os.path.join(SCRIPT_DIRECTORY, "server.js")]


of course there might be some corner cases to take care of, but we should assume we can run tests similar to this cli:
python reftest/remotereftest.py --deviceIP=...

Updated

8 years ago
Blocks: 579566
(Assignee)

Comment 1

8 years ago
Created attachment 475101 [details] [diff] [review]
fix reftest server path for remote testing (1.0)

patch which does what the bug proposes.  Tested in a few scenarios and this seems to do the trick.
Assignee: nobody → jmaher
Attachment #475101 - Flags: review?(ctalbert)

Updated

8 years ago
Attachment #475101 - Flags: review?(ctalbert) → review+

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/92d0663ca54c
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Component: New Frameworks → General
Product: Testing → Testing
You need to log in before you can comment on or make changes to this bug.