595276 - use something other than attrmodified to handle updates?

Status: RESOLVED INVALID

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Ian Gilman [:iangilman]]

Panorama currently watches attrmodified on all tabs (via AllTabs.jsm) in order to keep all of the tab thumbnails and related information up do date. Dietrich has pointed out that this may not be the most efficient solution. This bug is for looking for other options that provide the required functionality but without the performance hit.

In the Panorama code the area of interest is TabItems._update(), which is triggered by an event handler set up in TabItems.init().

Comment 1

[Ian Gilman [:iangilman]]

See: 

https://bugzilla.mozilla.org/show_bug.cgi?id=556007#c58

... for a related discussion.

Comment 2

[Dietrich Ayala (:dietrich)]

sicking says perf is bad *and* there are significant security bugs, so marking blocking.

Comment 3

[Ian Gilman [:iangilman]]

Comment from Dao (in bug 595076): 

"AllTabs.register("attrModified", ...) is the TabAttrModified event, which is
different from DOMAttrModfied."

Maybe this is a red herring?

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I should note that there are no (known) security issues with *using* mutation events, however we (and all other browsers) have had a significant number of bugs *implementing* them, so we're all hoping to deprecate them and replace them with something better.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Comment from Dao (in bug 595076): 
> 
> "AllTabs.register("attrModified", ...) is the TabAttrModified event, which is
> different from DOMAttrModfied."
> 
> Maybe this is a red herring?

Yeah.