Rename "TabPin" to "TabPinned" and "TabUnpin" to "TabUnpinned"

RESOLVED FIXED in Firefox 4.0b7

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({dev-doc-complete})

Trunk
Firefox 4.0b7
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
See bug 593872 comment 9.
(Assignee)

Comment 1

8 years ago
Created attachment 474169 [details] [diff] [review]
Patch (v1)
Attachment #474169 - Flags: review?(dao)

Updated

8 years ago
Attachment #474169 - Flags: review?(dao) → review+
(Assignee)

Updated

8 years ago
Attachment #474169 - Flags: approval2.0?
Comment on attachment 474169 [details] [diff] [review]
Patch (v1)

There are comments in the test that could use updating too...
Attachment #474169 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 3

8 years ago
Created attachment 474229 [details] [diff] [review]
For check-in
Attachment #474169 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/c4c9b356c106
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Documented the pinned attribute for tabs, which was not yet documented:

https://developer.mozilla.org/en/XUL/Attribute/pinned

That's linked to from:

https://developer.mozilla.org/en/XUL/tab

Documented the pinTab and unpinTab methods on tabbrowser, which also was not yet documented:

https://developer.mozilla.org/en/XUL/Method/pinTab
https://developer.mozilla.org/en/XUL/Method/unpinTab

Those are linked from:

https://developer.mozilla.org/en/XUL/tabbrowser

And the TabPinned and TabUnpinned events are now documented as well (as well as any of our events are documented, anyway):

https://developer.mozilla.org/en/Code_snippets/Tabbed_browser#Notification_when_a_tab_is_pinned_or_unpinned

Firefox 4 for developers is also updated. Whew!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.