59531 - tabbox orientation works different in different skins

Status: RESOLVED INVALID

(Core :: XUL, defect, P4)

Description

[Eric Plaster]

Setting the orient attribute in a <tabbox> doesn't change the orientation of the
tabs in modern.  If I use a "align" attribute howerver it works correctly.

John Morrison prompted me to add this bug.  You can find our discution on
npm.xpfe titled "tabbox orientation" on 11/6/00.

In his words:
Er, now I'm confused. These are behaving differently in Modern vs. Classic (and
SkyPilot). 'align' is deprecated, and it looks like when the tab widget moved
into XBL, that was left behind perhaps unintentionally.

Comment 1

[Keyser Sose]

Reporter is this still a problem in the latest nightly builds?

Comment 2

[Keyser Sose]

Marking INVALID due to lack of response and date of bug report. If this is still
a problem in the latest nightlies feel free to reopen it.

Comment 3

[John Morrison]

Attachment: tabcontrol orient='horizontal'; tabbox orient|align='vertical'; text/xul

Comment 4

[John Morrison]

reopening. this is a bug.

Comment 5

[Keyser Sose]

Ok I see this now. Marking NEW.

Platform: PC
OS: Linux 2.2.16
Mozilla Build: 2000122808 M18 Trunk Build


Marking NEW.

Comment 6

[Eric Plaster]

Sorry for the no response.  I must have missed the emails...

Anyway, using mozilla 0.7 (build ID:00000000) it still won't align the tabs
vertically using orient.  Interestingly though, both modern and classic wont
now, but blue does.  Using "align" seems to make it work in modern, but breaks
the blue.

Hope this helps.

Comment 7

[Joe Hewitt (gone)]

taking

Comment 8

[Mark Anderson]

This bug is fixed, isn't it?

Comment 9

[John Morrison]

No, with updated syntax for tab controls, the same issue is still present. 
I'll attach the updated testcase which partially works for Modern, although
it depends on the use of deprecated 'align' to make it work. In general, 
though, this is just one of a number of things that would need to be fixed
before the support for vertical side tabs was reasonably good.

Comment 10

[John Morrison]

Attachment: updated testcase; semi-works in Modern, doesn't work in Classic.

Comment 11

[Mark Anderson]

Ah.  The fact that I wasn't importing the style sheets of the applied skin would 
explain why I wasn't seeing it. :)

Comment 12

[Mark Anderson]

Here.  Have a patch that fixes Modern.  (I tried something similar in Windows 
Classic, but it requires more work than that, and I have to sleep. ;) )

Comment 13

[Mark Anderson]

Attachment: Patch for Modern to allow vertical tabs

Comment 14

[Mark Anderson]

Attachment: Windows Classic patch (I think Mac Classic already works for it)

Comment 15

[Mark Anderson]

Ok, I'm fairly certain this bug has disappeared now, due to a slightly differing 
implementation of <tabs> (perhaps due to the tab browser?).  Recommend 
WORKSFORME or INVALID.

Comment 16

[Asa Dotzler [:asa]]

no longer valid.