Closed Bug 595343 Opened 9 years ago Closed 9 years ago

Remote tab titles are always URLs

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We have some bad logic in the Awesomescreen logic when setting the row title. We have code to fallback to use the page URL if the title is null, but the logic is flipped the wrong way. So we _always_ get URLs for titles.
Attachment #474204 - Flags: review?(mbrubeck)
Comment on attachment 474204 [details] [diff] [review]
patch

Let's make that:

  title: title || pageUrl,

r=mbrubeck with that change
Attachment #474204 - Flags: review?(mbrubeck) → review+
pushed with change:
http://hg.mozilla.org/mobile-browser/rev/0dd4d20dd22d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110913
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.