Manually-inserted <script src> and <link href> tags are missing the mtime filter

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

3.7.3
Bugzilla 4.0
Bug Flags:
approval +
approval4.0 +
blocking4.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
comments.js does not have a ?12345 after it in the source, because it's a manually-inserted <script src> tag in the code. There may be other places where this is a problem as well.
Flags: blocking4.0+
(Assignee)

Updated

8 years ago
Summary: Manually-inserted <script src> tags are missing the mtime filter → Manually-inserted <script src> and <link href> tags are missing the mtime filter
(Assignee)

Comment 1

8 years ago
Created attachment 477000 [details] [diff] [review]
v1

This renames the filter to "mtime" (shorter) and uses it everywhere that I could find a <script src> or <link href> (CSS) tag.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #477000 - Flags: review?(bugzilla)
Comment on attachment 477000 [details] [diff] [review]
v1

r=glob
Attachment #477000 - Flags: review?(bugzilla) → review+
Flags: approval?
(Assignee)

Updated

8 years ago
Flags: approval?
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 3

8 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Template.pm
modified template/en/default/attachment/diff-header.html.tmpl
modified template/en/default/bug/comments.html.tmpl
modified template/en/default/flag/list.html.tmpl
modified template/en/default/global/header.html.tmpl
modified template/en/default/list/list-simple.html.tmpl
Committed revision 7491.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/                         
modified Bugzilla/Template.pm
modified template/en/default/attachment/diff-header.html.tmpl
modified template/en/default/bug/comments.html.tmpl
modified template/en/default/flag/list.html.tmpl
modified template/en/default/global/header.html.tmpl
modified template/en/default/list/list-simple.html.tmpl
Committed revision 7419.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.