Closed Bug 595435 Opened 9 years ago Closed 9 years ago

"ASSERTION: Invalid offset" and more with rtl, huge line-height

Categories

(Core :: Layout, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+
status1.9.2 --- unaffected

People

(Reporter: jruderman, Assigned: smontagu)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files, 1 obsolete file)

Attached file testcase
###!!! ASSERTION: Invalid offset: 'aOffset <= mSkipChars->mCharCount', file gfx/thebes/gfxSkipChars.cpp, line 92

###!!! ASSERTION: Text run does not map enough text for our reflow: 'gfxSkipCharsIterator(iter).ConvertOriginalToSkipped(offset + length) <= mTextRun->GetLength()', file layout/generic/nsTextFrameThebes.cpp, line 6385
blocking2.0: --- → ?
blocking2.0: ? → final+
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → smontagu
Attachment #486788 - Flags: review?(roc)
-      length = newLineOffset + 1 - offset;
+      length = contentNewLineOffset + 1 - offset;

Why this change?
Attached patch Corrected patchSplinter Review
Attachment #486788 - Attachment is obsolete: true
Attachment #486792 - Flags: review?(roc)
Attachment #486788 - Flags: review?(roc)
Comment on attachment 486792 [details] [diff] [review]
Corrected patch

need test too
Attachment #486792 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/06ec9fa89d20 (test)
http://hg.mozilla.org/mozilla-central/rev/1dad59de62c4
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
The testcase still triggers the same 4 assertions, so the patch didn't fix this bug as described in comment 0.  Furthermore, the crashtest is marked as triggering 4 assertions without a bug number.

If the patch didn't fix this bug, what did it do?
Status: RESOLVED → REOPENED
OS: Mac OS X → All
Resolution: FIXED → ---
Depends on: 610331
(In reply to comment #7)
> The testcase still triggers the same 4 assertions, so the patch didn't fix this
> bug as described in comment 0. 

That would be because there were strange failures on a couple of tinderboxes (I think as a result of checking in just before the end of DST) and I backed out. Now relanded:

http://hg.mozilla.org/mozilla-central/rev/3e76ac6c6be7
http://hg.mozilla.org/mozilla-central/rev/70657efea2df

> Furthermore, the crashtest is marked as
> triggering 4 assertions without a bug number.

Filed bug 610331 and updated the manifest to refer to it.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.