595569 - Deleting a product/component throws an error

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

Try to delete a product from editproducts.cgi. In 4.1 only, you get the following error:

 visibility_value_id is not a valid parameter for the Bugzilla::Field::match function.

Traceback:

 at Bugzilla/Object.pm line 445
	Bugzilla::Object::_check_field(...) called at Bugzilla/Object.pm line 228
	Bugzilla::Object::match(...) called at Bugzilla/Field.pm line 256
	Bugzilla::Field::match(...) called at Bugzilla/Field/ChoiceInterface.pm line 113
	Bugzilla::Field::ChoiceInterface::controls_visibility_of_fields(...) called at Bugzilla/Field/ChoiceInterface.pm line 41
	Bugzilla::Field::ChoiceInterface::_check_if_controller(...) called at Bugzilla/Product.pm line 272
	Bugzilla::Product::remove_from_db(...) called at /var/www/html/bugzilla/editproducts.cgi line 235

Comment 1

[Tiago Mello [:timello]]

True.

Comment 2

[Tiago Mello [:timello]]

Also, that happens when removing components.

Comment 3

[Tiago Mello [:timello]]

Attachment: v1

Comment 4

[Frédéric Buclin]

This also prevents field values from being deleted, in editvalues.cgi.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 474962 [details] [diff] [review]
v1

>=== modified file 'Bugzilla/Field/ChoiceInterface.pm'
>+            "SELECT id FROM fielddefs
>+               INNER JOIN field_visibility ON id = field_id
>+             WHERE value_id = ? AND visibility_field_id = ?", undef,

  You don't need that INNER JOIN, you just need to select field_id from field_visibility, and make sure that you do SELECT DISTINCT.

Comment 6

[Tiago Mello [:timello]]

(In reply to comment #5)
> Comment on attachment 474962 [details] [diff] [review]
> v1
> 
> >=== modified file 'Bugzilla/Field/ChoiceInterface.pm'
> >+            "SELECT id FROM fielddefs
> >+               INNER JOIN field_visibility ON id = field_id
> >+             WHERE value_id = ? AND visibility_field_id = ?", undef,
> 
>   You don't need that INNER JOIN, you just need to select field_id from
> field_visibility, and make sure that you do SELECT DISTINCT.

Yes, we do need. value_id is not unique in field_visibility the primary key is both columns.

Comment 7

[Frédéric Buclin]

Increasing severity as it affects several parts of administration, see comments 2 and 4. This prevents me from doing some QA too.

Comment 8

[Max Kanat-Alexander]

Comment on attachment 474962 [details] [diff] [review]
v1

>=== modified file 'Bugzilla/Field/ChoiceInterface.pm'
>+               INNER JOIN field_visibility ON id = field_id

  id and field_id should have table names on them, to be clear.

  Otherwise this looks fine. :-)

Comment 9

[Tiago Mello [:timello]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/                                                  
modified Bugzilla/Field/ChoiceInterface.pm
Committed revision 7548.