595636 - :-moz-submit-invalid should not apply to disabled submit buttons

Status: RESOLVED WONTFIX

(Core :: Layout: Form Controls, defect)

Description

[philippe (part-time)]

Attachment: minimal testcase

When a input[type="submit"] is disabled, :-moz-submit-invalid should not apply.

forms.css should probably be updated to include something like
input[type="submit"][disabled]:-moz-submit-invalid {
  box-shadow: none;
}

(beside, it looks silly on OS X, where disabled buttons are semi-opaque; the reddish glow applies as background...)

Comment 1

[Mounir Lamouri (:mounir)]

We should probably fix that before shipping.

Comment 2

[Mounir Lamouri (:mounir)]

We are going to remove the default style for :-moz-submit-invalid (see bug 600151). So, as soon as the default style will be removed, this bug will be solved.
Note: :-moz-submit-invalid will be working on disabled button, authors will have to use :-moz-submit-invalid:enabled if they prefer to not have the style applying on disabled buttons.

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> We are going to remove the default style for :-moz-submit-invalid (see bug
> 600151). So, as soon as the default style will be removed, this bug will be
> solved.

Not really. On the surface maybe, but conceptually, the problem remains.Imho.
(I mean, removing the default styling for :-moz-submit-invalid feels like it is just a quick hack to get rid of the visibility of the issue)

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to comment #3)
> Not really. On the surface maybe, but conceptually, the problem remains.Imho.
> (I mean, removing the default styling for :-moz-submit-invalid feels like it is
> just a quick hack to get rid of the visibility of the issue)

We are not removing the default style because of this bug. The UX (User eXperience) person working with us on web forms thing that the red glow on the invalid submit buttons is much more confusing than helping so we are going to remove it for beta 8.
We didn't know what to do with this bug: changing the rule in forms.css or make :-moz-submit-invalid not applying on disabled buttons. With the default style being removed, we don't have to change forms.css anymore and it will be up to the authors.

Comment 5

[Mounir Lamouri (:mounir)]

So, we do not have a default style for :-moz-submit-invalid anymore (with bug 600151 resolved).
If authors want to use :-moz-submit-invalid and don't want to have the style applied on disabled elements, they can use :-moz-submit-invalid:enabled.