Closed
Bug 595639
Opened 15 years ago
Closed 15 years ago
Prevent badges handlers to access the awesome row directly
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file)
|
3.89 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
This patch wrap the row into a structure to prevent the handler to access it directly and set a badge on the wrong item.
Attachment #474519 -
Flags: review?(mark.finkle)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 474519 [details] [diff] [review]
Patch
>diff -r 2cf977860f46 chrome/content/bindings.xml
>+ let currentUrl = item.getAttribute("url");
currentURL
>+ if (!aBadge || aBadge == "")
>+ item.removeAttribute("badge");
>+ else
>+ item.setAttribute("badge", aBadge);
Fix indent
Can you change "pageUrl" to "pageURL" here too? I missed that one
http://mxr.mozilla.org/mobile-browser/source/chrome/content/bindings.xml#1219
Attachment #474519 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Comment 2•15 years ago
|
||
Addressed comments.
http://hg.mozilla.org/mobile-browser/rev/66224c0d28aa
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•