595639 - Prevent badges handlers to access the awesome row directly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch wrap the row into a structure to prevent the handler to access it directly and set a badge on the wrong item.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 474519 [details] [diff] [review]
Patch

>diff -r 2cf977860f46 chrome/content/bindings.xml
>+              let currentUrl = item.getAttribute("url");

currentURL

>+                      if (!aBadge || aBadge == "")
>+                        item.removeAttribute("badge");
>+                      else
>+                      item.setAttribute("badge", aBadge);

Fix indent

Can you change "pageUrl" to "pageURL" here too? I missed that one
http://mxr.mozilla.org/mobile-browser/source/chrome/content/bindings.xml#1219

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Addressed comments.

http://hg.mozilla.org/mobile-browser/rev/66224c0d28aa

Comment 3

[Dão Gottwald [:dao]]

bugspam