Closed
Bug 595649
Opened 14 years ago
Closed 14 years ago
about:home banner text too high on banner
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: wgianopoulos, Assigned: wgianopoulos)
Details
(Keywords: polish, Whiteboard: [about-home])
Attachments
(1 file, 2 obsolete files)
|
629 bytes,
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
The banner text is neither centered vertically across the banner nor does it have larger top padding than bottom padding as is more conventional. The way it is just looks wrong.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474527 -
Attachment description: vix → fix
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → bill
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474527 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Actually, this looks better.
Attachment #474527 -
Attachment is obsolete: true
Attachment #474528 -
Flags: review?(gavin.sharp)
Attachment #474527 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Oops! Wrong patch.
Attachment #474528 -
Attachment is obsolete: true
Attachment #474529 -
Flags: review?(gavin.sharp)
Attachment #474528 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474529 -
Attachment description: vix v2a → fix v2a
|
||
Updated•14 years ago
|
Attachment #474529 -
Flags: review?(gavin.sharp)
Attachment #474529 -
Flags: review+
Attachment #474529 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/18d0678220e2
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Summary: about home banner text too high on banner → about:home banner text too high on banner
Target Milestone: --- → Firefox 4.0b6
|
||
Comment 5•14 years ago
|
||
fwiw, the original page (http://www.google.it/firefox/) has text in the same position, not centered and with more padding below. Since the request was to copy the original page and wait for a new design, that was not changed. But this is a welcome change.
|
|
||
Comment 6•14 years ago
|
||
ehr i posted the italian url, but it's the same just s/it/com/
|
|
||
Updated•13 years ago
|
Whiteboard: [about-home]
You need to log in
before you can comment on or make changes to this bug.
Description
•