Maximum password length is hardcoded in the UI when editing user accounts

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
Administration
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Artem Anisimov, Assigned: Artem Anisimov)

Tracking

3.6.2
Bugzilla 3.6
Bug Flags:
approval +
approval4.0 +
approval3.6 +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
User-Agent:       Opera/9.80 (X11; Linux i686; U; fr) Presto/2.6.30 Version/10.61
Build Identifier: Bugzilla 3.6.2

As http://planet.bugzilla.org/ tells, Bugzilla 3.6 has support for unlimited length of passwords. However, forms that are used to input and modify password (for example, template/en/default/admin/users/userdata.html.tmpl) sets maximum length of password to 16 without notifying an operator of this limitation. I believe that such limitations need to be removed.

Reproducible: Always
(Assignee)

Updated

7 years ago
Version: unspecified → 3.6.2

Comment 1

7 years ago
Ah yes, you are right. Do you want to write the patch which removes size="16" maxlength="16"? I can review it.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
Summary: Maximum password length is hardcoded in web forms. → Maximum password length is hardcoded in the UI when editing user accounts
Target Milestone: --- → Bugzilla 3.6

Comment 2

7 years ago
(In reply to comment #1)
> Ah yes, you are right. Do you want to write the patch which removes size="16"
> maxlength="16"? I can review it.

Or rather, just remove maxlength. No need to remove size, IMO.
(Assignee)

Comment 3

7 years ago
(In reply to comment #1)
> Ah yes, you are right. Do you want to write the patch which removes size="16"
> maxlength="16"? I can review it.

Well, let's give it a try.
(Assignee)

Comment 4

7 years ago
Created attachment 475138 [details] [diff] [review]
Proposed patch
(Assignee)

Updated

7 years ago
Attachment #475138 - Attachment is patch: true
Attachment #475138 - Attachment mime type: application/octet-stream → text/plain

Comment 5

7 years ago
Comment on attachment 475138 [details] [diff] [review]
Proposed patch

>-      <td><input size=64 maxlength=64 name="classification"></td>
>+      <td><input size="64" maxlength="64" name="classification"></td>

This change is unrelated to the bug. No need to include it.


>       <input type="password" id="Bugzilla_password" name="Bugzilla_password"
>-             maxlength="20" size="20">
>+             size="20">

Nit: we could write size="20" on the previous line, as it's now short enough.


>-      <input type="password" size="16" maxlength="16" name="password"
>+      <input type="password" size="16" name="password"
>              autocomplete="off"

Nit: same here.


Would you agree to fix these comments and re-attach a patch? Else I can do it on checkin. Anyway, your patch looks good. Thanks for writing it. :) r=LpSolit
Attachment #475138 - Flags: review+

Updated

7 years ago
Assignee: administration → aanisimov
Status: NEW → ASSIGNED
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+

Updated

7 years ago
Depends on: 471620
(Assignee)

Comment 6

7 years ago
Created attachment 475149 [details] [diff] [review]
Corrected proposed patch
Attachment #475138 - Attachment is obsolete: true
(Assignee)

Comment 7

7 years ago
Created attachment 475150 [details] [diff] [review]
Fix for a small typo

Comment 8

7 years ago
Comment on attachment 475149 [details] [diff] [review]
Corrected proposed patch

Thanks! :) r=LpSolit
Attachment #475149 - Attachment is patch: true
Attachment #475149 - Flags: review+

Comment 9

7 years ago
Comment on attachment 475150 [details] [diff] [review]
Fix for a small typo

Yeah, we don't need this one as part of this bug.
Attachment #475150 - Attachment is obsolete: true
Attachment #475150 - Attachment is patch: true

Comment 10

7 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/admin/sudo.html.tmpl
modified template/en/default/admin/users/userdata.html.tmpl
Committed revision 7469.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified template/en/default/admin/sudo.html.tmpl
modified template/en/default/admin/users/userdata.html.tmpl
Committed revision 7399.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/admin/sudo.html.tmpl
modified template/en/default/admin/users/userdata.html.tmpl
Committed revision 7172.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.