595750 - Unify Gecko chrome manipulation in one place

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Patch

This is another bug that consists entirely of uninteresting build system changes.

We currently have two places where parts of our Gecko chrome manipulation lives, embed-replacements and pinstripe.  On 1.9.2, neither of them have names that correspond to anything extant, since the embed-replacements Makefile rules are gone and replacing is handled by the jar system now, and since pinstripe's Makefile and jar.mn handle all of our jar-packing, and none of that work is pulling in toolkit/themes/pinstripe/ theme files any more.  

When we did the build system work for 1.9.2, I mentioned I wanted to clean them up at some point (now that we could do so and preserve history) but that it was easier to defer until some other time.  Adding branding yesterday reminded me of this, so now is that time.

This patch unifies the remaining bits of both manipulation sites into a generic-yet-descriptively-named location, geckochrome.  The patch moves all the replacement/modified chrome files from embed-replacements into geckochrome, moves the build system drivers (Makefile.in, jar.mn) from pinstripe to geckochrome, modifies the jar.mn for the new paths, and edits the main Camino Makefile to 'make' in geckochrome rather than in pinstripe.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 474602 [details] [diff] [review]
Patch

The "Raw Unified" and "Diff" views get all confused by this patch (which is a bunch of "hg mv" plus a bit of jar.mn editing after the mv); for the patch to make any sense at all, you'll have to use the "View" view, or look at it in the <iframe> in the "Edit" view.

Comment 2

[Stuart Morgan]

Comment on attachment 474602 [details] [diff] [review]
Patch

sr=smorgan

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/b2d0ea6f2c8e

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix makefiles.sh, too

Ooops, I forgot about makefiles.sh (which is used to mass-generate Makefiles from Makefile.ins at the start of a build) when I fixed this bug :(

Comment 5

[Stuart Morgan]

Comment on attachment 488123 [details] [diff] [review]
Fix makefiles.sh, too

sr=smorgan

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/5495eb82d0c3 for makefiles.sh