595766 - bustage Win64 build due to UnsetVMFrameRegs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Makoto Kato [:m_kato]]

link -NOLOGO -OUT:js.exe -PDB:js.pdb  -NXCOMPAT -DYNAMICBASE  -DEBUG -DEBUGTYPE:
CV   js.obj jsworkers.obj  c:/Workspace/hg.mozilla.org/objdir-tm-win64-dbg/dist/
lib/nspr4.lib c:/Workspace/hg.mozilla.org/objdir-tm-win64-dbg/dist/lib/plc4.lib
c:/Workspace/hg.mozilla.org/objdir-tm-win64-dbg/dist/lib/plds4.lib @../js_static
.lib.fake kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib
LINK : js.exe not found or not built by the last incremental link; performing fu
ll link
   Creating library js.lib and object js.exp
TrampolineMasmX64.obj : error LNK2019: unresolved external symbol UnsetVMFrameRe
gs referenced in function JaegerTrampoline

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 474625 [details] [diff] [review]
fix

>+        /* we need pad the stack */

Nit: Reads better as "X64 needs to pad the stack."

Comment 3

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/tracemonkey/rev/aa65a38ae90b

Comment 4

[Armen [:armenzg]]

(In reply to comment #3)
> http://hg.mozilla.org/tracemonkey/rev/aa65a38ae90b

Perfect.
Do we know when the next merge will be?
Could I please ask for landing this on trunk since it blocks my testing on the 64-bit build machines?

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/aa65a38ae90b