test_AddonRepository_cache.js is connecting https://versioncheck.addons.mozilla.org/

VERIFIED FIXED in mozilla2.0b7

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Ginn Chen, Assigned: mossop)

Tracking

Trunk
mozilla2.0b7
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
I don't know if it is expected.
But I think test suite should not try to connect a production server.

Here's the log.

....
TEST-PASS | /export/home/ginn/work/mozilla-central/release/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack/test_AddonRepository_cache.js | [anonymous : 335] false == false
TEST-PASS | /export/home/ginn/work/mozilla-central/release/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack/test_AddonRepository_cache.js | [anonymous : 339] false == false
TEST-PASS | /export/home/ginn/work/mozilla-central/release/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack/test_AddonRepository_cache.js | [check_database_exists : 312] true == true
*** LOG addons.updates: Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=test_AddonRepository_2@tests.mozilla.org&version=1.2&maxAppVersion=1&status=userDisabled&appID=xpcshell@tests.mozilla.org&appVersion=1&appOS=XPCShell&appABI=noarch-spidermonkey&locale=en-US&currentAppVersion=1&updateType=112
*** LOG addons.updates: Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=test_AddonRepository_3@tests.mozilla.org&version=1.3&maxAppVersion=1&status=userDisabled&appID=xpcshell@tests.mozilla.org&appVersion=1&appOS=XPCShell&appABI=noarch-spidermonkey&locale=en-US&currentAppVersion=1&updateType=112
*** LOG addons.updates: Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=test_AddonRepository_1@tests.mozilla.org&version=1.1&maxAppVersion=1&status=userEnabled&appID=xpcshell@tests.mozilla.org&appVersion=1&appOS=XPCShell&appABI=noarch-spidermonkey&locale=en-US&currentAppVersion=1&updateType=112
(Assignee)

Comment 1

8 years ago
It's not a big deal, I don't think any tests are relying on AMO, but we should make the automated test suite use a testing server for the add-on update checks.
(Reporter)

Comment 2

8 years ago
I met this problem because our unittest buildbot machine has some problems with network connection.
Therefore, it always timeout at this test.

I've added "127.0.0.1 versioncheck.addos.mozilla.org" to /etc/hosts to get around.
(Assignee)

Comment 3

8 years ago
Created attachment 475273 [details] [diff] [review]
patch rev 1

Makes the update and blocklist urls point to the testing server for safety.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #475273 - Flags: review?(gavin.sharp)
Comment on attachment 475273 [details] [diff] [review]
patch rev 1

rs=me...
Attachment #475273 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 5

8 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/6141e54444c0
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Gin, could you please verify the fix? Thanks.
Version: unspecified → Trunk
(Reporter)

Comment 7

8 years ago
fix failed.

If you want to test it, you can add
127.0.0.2 versioncheck.addons.mozilla.org
to /etc/hosts
It will cause timeout for this case.

Is automation.py used by "make xpcshell-tests"?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

8 years ago
Created attachment 477640 [details] [diff] [review]
patch rev 2

Damn, totally patched the wrong test suite. Well nm it's useful anyway. Here is a better one:
Attachment #477640 - Flags: review?(robert.bugzilla)
Attachment #477640 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 9

8 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/14b390aa5b85
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Verified fixed by check-in.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.