595831 - test_AddonRepository_cache.js is connecting https://versioncheck.addons.mozilla.org/

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ginn Chen]

I don't know if it is expected.
But I think test suite should not try to connect a production server.

Here's the log.

....
TEST-PASS | /export/home/ginn/work/mozilla-central/release/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack/test_AddonRepository_cache.js | [anonymous : 335] false == false
TEST-PASS | /export/home/ginn/work/mozilla-central/release/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack/test_AddonRepository_cache.js | [anonymous : 339] false == false
TEST-PASS | /export/home/ginn/work/mozilla-central/release/_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack/test_AddonRepository_cache.js | [check_database_exists : 312] true == true
*** LOG addons.updates: Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=1.2&maxAppVersion=1&status=userDisabled&appID=[e-mail]&appVersion=1&appOS=XPCShell&appABI=noarch-spidermonkey&locale=en-US&currentAppVersion=1&updateType=112
*** LOG addons.updates: Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=1.3&maxAppVersion=1&status=userDisabled&appID=[e-mail]&appVersion=1&appOS=XPCShell&appABI=noarch-spidermonkey&locale=en-US&currentAppVersion=1&updateType=112
*** LOG addons.updates: Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=1.1&maxAppVersion=1&status=userEnabled&appID=[e-mail]&appVersion=1&appOS=XPCShell&appABI=noarch-spidermonkey&locale=en-US&currentAppVersion=1&updateType=112

Comment 1

[Dave Townsend [:mossop]]

It's not a big deal, I don't think any tests are relying on AMO, but we should make the automated test suite use a testing server for the add-on update checks.

Comment 2

[Ginn Chen]

I met this problem because our unittest buildbot machine has some problems with network connection.
Therefore, it always timeout at this test.

I've added "127.0.0.1 versioncheck.addos.mozilla.org" to /etc/hosts to get around.

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Makes the update and blocklist urls point to the testing server for safety.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 475273 [details] [diff] [review]
patch rev 1

rs=me...

Comment 5

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/6141e54444c0

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Gin, could you please verify the fix? Thanks.

Comment 7

[Ginn Chen]

fix failed.

If you want to test it, you can add
127.0.0.2 versioncheck.addons.mozilla.org
to /etc/hosts
It will cause timeout for this case.

Is automation.py used by "make xpcshell-tests"?

Comment 8

[Dave Townsend [:mossop]]

Attachment: patch rev 2

Damn, totally patched the wrong test suite. Well nm it's useful anyway. Here is a better one:

Comment 9

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/14b390aa5b85

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed by check-in.