web console height resizing should count border and padding too

RESOLVED WORKSFORME

Status

--
minor
RESOLVED WORKSFORME
8 years ago
4 months ago

People

(Reporter: mcdavis941.bugs, Unassigned)

Tracking

Trunk
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [console-3][good first bug])

Attachments

(1 attachment)

The vertical resizing of the Web Console input box is a great improvement but doesn't take into account border and padding on the textbox.  (Screenshot coming.)

Is there a way to calculate the height so it takes all size-related styling into account?  scrollHeight apparently doesn't.

As a result, if the textbox has padding and border, you have the textbox getting shorter as soon as the user starts typing into it.  It grows in height with each new row of input, but it's never quite as tall as it needs to be.

On first input, the height decreases (DEcreases) by 9px, exactly the amount of vertical border and padding on the textbox in my case.

With Winstripe:
                                        margin      border      padding
hbox.jsterm-input-container             0           0           0
  textbox.jsterm-input-node             2 4 2 4     0           0 0 0 16
    hbox.textbox-input-box              0           0           0
      html:textarea.textbox-textarea    0           0           0

In my case:
                                        margin      border      padding
hbox.jsterm-input-container             0           0           0
  textbox.jsterm-input-node             2 4 2 4     2 2 2 2     2 2 3 13
    hbox.textbox-input-box              0           0           0
      html:textarea.textbox-textarea    0           0           0

Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b6pre) Gecko/20100912 Firefox/4.0b6pre

STR:

1. Install NNL nightly (will follow up with link after I post it)
2. Restart with it
3. Open web console in any page
4. Start typing in the console input textbox
5. Notice the height change and cropped contents
See bug 588967, which added console input height resizing.
Blocks: 588967

Updated

8 years ago
Blocks: 594225

Comment 4

8 years ago
Is this the same as bug 601352?

Comment 5

8 years ago
(In reply to comment #4)
> Is this the same as bug 601352?

I do not think so.
Whiteboard: [console-3]

Updated

7 years ago
Whiteboard: [console-3] → [console-3][good first bug]

Comment 6

7 years ago
(Link to .jar is 404)

Is this bug still valid today?

Updated

7 years ago
Assignee: nobody → sonny.piers

Updated

7 years ago
Assignee: sonny.piers → nobody
(In reply to Paul Rouget [:paul] from comment #6)
> (Link to .jar is 404)
> 
> Is this bug still valid today?

don't think so. Closing, reopen if needed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.