595900 - TBPL needs unit tests

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: TBPL, defect)

Description

[Arpad Borsos [:Swatinem]]

TBPL needs unit tests desperately, so things don’t break on every other checkin.
I must say I have zero experience testing interactive websites that depend on foreign apis, for posting comments on bugzilla or staring builds on tinderbox.

For frontend testing I guess selenium should be good, but how can we test bugzilla/tinderbox pushing reliably?

Comment 1

[Phil Ringnalda (:philor)]

First two thoughts off the top of my head for Tinderbox: use http://tinderbox-stage.mozilla.org/ (and somehow deal with the way that you have no idea what will be failing or how at the time you run tests), or, run a test "Tinderbox" with a faked up JSON and faked logs. Dunno if the Bugzilla API is staged on landfill.bugzilla.org or not.

Comment 2

[(no longer active)]

(In reply to comment #1)
> Dunno if the Bugzilla API
> is staged on landfill.bugzilla.org or not.

Gerv will know that.

Comment 3

[Markus Stange [:mstange]]

Most regression bugs we had to deal with recently were in UserInterface.js and close friends, so I'll focus on automating that first. All communication with external things can be emulated with mock objects for a start.

Comment 4

[Gervase Markham [:gerv]]

There currently isn't a test install of the BzAPI available, because the Bugzilla staging server that the test install of BzAPI was pointed at got locked down due to possible security risks. I need to re-point it at a new landfill instance, but have not yet done so. It's on my list. Keep an eye on mozilla.tools for updates.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Test BzAPI now available. See:
https://wiki.mozilla.org/Bugzilla:REST_API#Servers

Gerv

Comment 6

[Arpad Borsos [:Swatinem]]

Bugs 599425 and 599551 are victims of not having automated tests for comment submission. (And my fault of not testing that manually)

Comment 7

[Ed Morley [:emorley]]

This is fixed in Treeherder.
Wontfix here since TBPL is nearing EOL.