Closed
Bug 595954
Opened 14 years ago
Closed 14 years ago
use setAttribute when setting type for notifications
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | beta7+ |
People
(Reporter: mconnor, Assigned: mconnor)
References
Details
Attachments
(1 file)
|
838 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
This seems to not work under certain conditions involving hidden elements. In theory, the property sets the attribute, and gets the attribute, but this doesn't appear to be consistently reliable.
Attachment #474770 -
Flags: review?(gavin.sharp)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 474770 [details] [diff] [review]
v1
You need to switch .priority too, right?
Attachment #474770 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Yes, I do, will push with that.
Assignee: nobody → mconnor
blocking2.0: --- → beta6+
|
||
Comment 3•14 years ago
|
||
ETA?
|
|
||
Comment 4•14 years ago
|
||
Looks like dao already fixed this independently:
http://hg.mozilla.org/mozilla-central/rev/42082138c475
I'll just fix priority.
|
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•