Closed
Bug 596038
Opened 15 years ago
Closed 15 years ago
The before_table hook in list/table.html.tmpl needs to be moved higher in the template
Categories
(Bugzilla :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
The before_table hook is useful, but is unfortunately set after all these [% BLOCK %]. For some reason, altering abbrev from this hook has no effect. Moving the hook before the first block fixes this problem. Much wanted for 3.6.3.
|
Assignee | |
Updated•15 years ago
|
Severity: enhancement → minor
|
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
(In reply to comment #0)
> For some reason, altering abbrev from this hook has no effect.
Ah, the reason is obvious. We process tableheader before the hook, which make the hook pretty useless.
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 474888 [details] [diff] [review]
patch, v1
Oh, also, that should be BLOCK tableheader, and PROCESS tableheader, no? That's why we were confused. But that could be a separate patch.
Attachment #474888 -
Flags: review?(timello) → review+
|
|
||
Updated•15 years ago
|
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
|
|
Assignee | |
Comment 4•15 years ago
|
||
(In reply to comment #3)
> Oh, also, that should be BLOCK tableheader, and PROCESS tableheader, no?
I think so too, yes. And yes, let's keep that for another bug.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/list/table.html.tmpl
Committed revision 7468.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified template/en/default/list/table.html.tmpl
Committed revision 7398.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/list/table.html.tmpl
Committed revision 7171.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•