596041 - Leak analysis should have an extension architecture

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: TBPL, defect)

Description

[Justin Lebar (not reading bugmail)]

See bug 557479.  This intermittent leak is not recognized by tbpl's leakcheck script, but it should be.

Comment 1

[Phil Ringnalda (:philor)]

Morphing into the only way I can see for a bug about recognizing a leak that was fixed a year ago to still be useful. If the leak analysis page loaded all the files in /leak-analysis/extensions/, and either passed each line (plus probably the name of the suite, since you need to know whether it's in chrome or browser-chrome for a Moth leak) or a parsed-out set of the useful info, like a list of tests that leaked domwindows plus the list of leaked URLs and the list of leaked objects to a function defined in each, then bug557479.php could have said "Leaked 1 instance of VideoData during mochitest-1, this is probably bug 557479."

The current scheme, only looking for leaked domwindows, and having a single hard-coded heuristic for a single leak that we haven't had for ages, doesn't scale or maintain well.

Comment 2

[Markus Stange [:mstange]]

We should probably also port the script to JS so that it's easier hackable.

Comment 3

[Ed Morley [:emorley]]

Wontfix since TBPL is being replaced by Treeherder.