Closed
Bug 596078
Opened 14 years ago
Closed 13 years ago
remove 4.x plugin dir scan
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sgreenlay, Assigned: sgreenlay)
References
Details
Attachments
(1 file, 7 obsolete files)
|
13.53 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #475118 -
Flags: review?(joshmoz)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #475118 -
Attachment is obsolete: true
Attachment #475190 -
Flags: review?(joshmoz)
Attachment #475118 -
Flags: review?(joshmoz)
Comment on attachment 475190 [details] [diff] [review] Fixed Patch to Remove 4.x Plug-in Directory Filter You also need to remove the "isUnwantedPlugin" function. It is no longer used with your patch.
Attachment #475190 -
Flags: review?(joshmoz) → review-
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #475190 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Attachment #475544 -
Flags: review?(joshmoz)
Attachment #475544 -
Flags: review?(joshmoz)
|
|
Assignee | |
Comment 5•14 years ago
|
||
Removed unused compmanager var
Attachment #475544 -
Attachment is obsolete: true
Attachment #475581 -
Flags: review?(joshmoz)
Comment on attachment 475581 [details] [diff] [review] Fixed Patch to Remove 4.x Plug-in Directory Filter (v1.2) Looks good!
Attachment #475581 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #475581 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #475581 -
Flags: approval2.0?
|
|
Assignee | |
Comment 9•14 years ago
|
||
Updated patch to apply to trunk
Attachment #475581 -
Attachment is obsolete: true
Attachment #497672 -
Flags: review?(joshmoz)
|
||
Updated•13 years ago
|
Whiteboard: not-ready
|
||
Comment 10•13 years ago
|
||
Comment on attachment 497672 [details] [diff] [review] Fixed Patch to Remove 4.x Plug-in Directory Filter (v1.3) Patch doesn't apply any more. I can update it if you want, Scott.
Attachment #497672 -
Flags: review?(joshmoz)
|
|
||
Comment 11•13 years ago
|
||
Attachment #497672 -
Attachment is obsolete: true
Attachment #522304 -
Flags: review?(scott)
|
|
Assignee | |
Comment 12•13 years ago
|
||
Comment on attachment 522304 [details] [diff] [review] fix v1.4 Looks good to me and applies cleanly on trunk.
Attachment #522304 -
Flags: review?(scott) → review+
|
|
||
Comment 13•13 years ago
|
||
I think we should just go ahead and remove all of the 4x dir scanning code in one go, not just the filter. I don't think its even turn on for trunk.
|
|
||
Comment 14•13 years ago
|
||
Actually, a filtered scan is the default. However, I don't think we want any plugin that would actually be in that dir to load in Firefox 5, even among the ones our filter allowed. They'd probably be incredibly old.
|
|
||
Comment 15•13 years ago
|
||
Adds removal of the whole 4.x scan to Scott's patch. I checked for entries on a few Windows machines, nothing there, and I'm pretty sure we don't want any plugins old enough to actually be installed via the 4.x entries.
Attachment #522304 -
Attachment is obsolete: true
Attachment #523056 -
Flags: review?(benjamin)
|
||
Updated•13 years ago
|
Attachment #523056 -
Flags: review?(benjamin) → review+
Summary: Remove 4.x Plug-in Directory Filter → remove 4.x plugin dir scan
|
|
||
Comment 16•13 years ago
|
||
Attachment #523056 -
Attachment is obsolete: true
|
|
||
Comment 17•13 years ago
|
||
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/8b86086e5f0e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•