596079 - Merge content-types.html.tmpl with createformcontents.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Frédéric Buclin]

in attachment/, content-types.html.tmpl contains nothing more than a list of MIME types you can select from when attaching a new file. It brings no value being in a separate template. It could be in a BLOCK in createformcontents.html.tmpl. Once the merge is done, I plan to add a hook to this block so that extensions can alter the list of available MIME types.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Frédéric Buclin]

I'm going to take it for 4.0 too, so that we don't break extensions in the 4.x series (the hook is already at the right place).

Comment 3

[Tiago Mello [:timello]]

Comment on attachment 482837 [details] [diff] [review]
patch, v1

It's nice to have a hook for that! It looks good and it was tested!

Comment 4

[Frédéric Buclin]

Thanks :)

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
deleted template/en/default/attachment/content-types.html.tmpl
modified template/en/default/attachment/createformcontents.html.tmpl
Committed revision 7547.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
missing template/en/default/attachment/content-types.html.tmpl
modified template/en/default/attachment/content-types.html.tmpl
modified template/en/default/attachment/createformcontents.html.tmpl
Committed revision 7444.