Use AddonManager.UPDATE_WHEN_PERIODIC_UPDATE when checking for add-on updates

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Trunk
x86_64
Linux

Details

Attachments

(1 attachment)

Created attachment 474976 [details] [diff] [review]
patch

The metrics team uses the updateType when crunching stats for update pings. Fennec currently only passes AddonManager.UPDATE_WHEN_USER_REQUESTED, a holdover from Fennec 1.1 when we only did manual update checks.

This patch adds the periodic check, but reverts to the manual check if the timer is null, which happens here:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/extensions.js#609

After patch I see:

*** LOG addons.updates: Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=mobiletools@starkravingfinkle.org&version=1.2&maxAppVersion=2.0b1pre&status=userEnabled&appID={a23983c0-fd0e-11dc-95ff-0800200c9a66}&appVersion=2.0b1pre&appOS=Linux&appABI=x86_64-gcc3&locale=en-US&currentAppVersion=2.0b1pre&updateType=112

(updateType is 112 == periodic check)
Attachment #474976 - Flags: review?(21)
http://hg.mozilla.org/mobile-browser/rev/cdfe1db33202
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.