Closed Bug 596196 Opened 14 years ago Closed 14 years ago

Include a default blocklist.xml in Thunderbird for releases

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-thunderbird3.1 .5+, thunderbird3.1 .5-fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.3a1
Tracking Flags:
Tracking Status
blocking-thunderbird3.1 --- .5+
thunderbird3.1 --- .5-fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(2 files)

Current blocklist.xml
1.42 KB, application/xml
Details
The fix
2.29 KB, patch
Bienvenu
: review+
standard8
: approval-thunderbird3.1.5+
Details | Diff | Splinter Review 
Including a blocklist.xml will mean that Thunderbird users are protected from issues (e.g. crashes, incompatibilities etc) from very first startup rather than the first blocklist check which could be up to 24 hours later.

It also gives us a way to deploy blocklist changes should the automatic mechanism be disabled for some reason (as has recently been seen).
awesome idea
Attached file Current blocklist.xml — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        The fix
        — 
          — Splinter Review
      

    


  
Decided not to shoot for this for 3.1.4, will pick up in the next version.

        Attachment #475197 -
        Flags: review?(bienvenu)

    
    

    
  
Comment on attachment 475197 [details] [diff] [review]
The fix

+    <emItem id="langpack-vi-VN@firefox.mozilla.org">

is it even possible that we'd have this extension? Or is it just simpler to have the same blocklist as firefox?

        Attachment #475197 -
        Flags: review?(bienvenu) → review+

    
    

    
  
(In reply to comment #4)
> Comment on attachment 475197 [details] [diff] [review]
> The fix
> 
> +    <emItem id="langpack-vi-VN@firefox.mozilla.org">
> 
> is it even possible that we'd have this extension? Or is it just simpler to
> have the same blocklist as firefox?

This is what Thunderbird is currently being offered in the blocklist from AMO, I'd prefer just to keep the file exactly the same so that we can just download and insert the new version when necessary.

    
    

    
  
Checked in to trunk: http://hg.mozilla.org/comm-central/rev/b68ebe2264b3
Status: NEW → RESOLVED
blocking-thunderbird3.1: --- → .5+
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1

    
  

        Attachment #475197 -
        Flags: approval-thunderbird3.1.5?

    
    

    
  
Comment on attachment 475197 [details] [diff] [review]
The fix

This has been a trunk for a few days without any reported problems. So a=me.

        Attachment #475197 -
        Flags: approval-thunderbird3.1.5? → approval-thunderbird3.1.5+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: