596282 - Error in the js console if fullcount does not exists

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I've encountered this case with my gmail account (that I never really used)

result page I've on my gmail account:
https://mail.google.com/mail/feed/atomLine:%201

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 475125 [details] [diff] [review]
Patch

>-              this._lastCount = req.responseXML.getElementsByTagName("fullcount")[0].childNodes[0].nodeValue;
>+              let count = req.responseXML.getElementsByTagName("fullcount");
>+              if (count)
>+                this._lastCount = count[0].childNodes[0].nodeValue;

What about setting to 0 if no fullcount?

this._lastCount = count ? count[0].childNodes[0].nodeValue : 0;

how's that?

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Comment on attachment 475125 [details] [diff] [review]
> Patch
> 
> >-              this._lastCount = req.responseXML.getElementsByTagName("fullcount")[0].childNodes[0].nodeValue;
> >+              let count = req.responseXML.getElementsByTagName("fullcount");
> >+              if (count)
> >+                this._lastCount = count[0].childNodes[0].nodeValue;
> 
> What about setting to 0 if no fullcount?
> 
> this._lastCount = count ? count[0].childNodes[0].nodeValue : 0;
> 
> how's that?

wfm

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

you patch or me patch?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 475833 [details] [diff] [review]
Patch v0.2

Clear to land for b1

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/a292fad385ac

Comment 7

[Dão Gottwald [:dao]]

bugspam