596296 - jsbridge should not include debug addons out of the box

Status: VERIFIED DUPLICATE of bug 602284

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

jsbridge currently has convenience debug addons:

http://github.com/mozautomation/mozmill/tree/master/jsbridge/jsbridge/xpi/

This is bad for a few reasons:

 - having these extensions means that you're not testing OOTB firefox, you are testing firefox with these extensions

 - these extensions need to be updated manually

 - these extensions should be removed manually before rolling into mozilla central

While there is convenience gained by the user in having these extensions available, we should find a way to provide this convenience without having these binary extensions replicated in our tree.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #0)
>  - having these extensions means that you're not testing OOTB firefox, you are
> testing firefox with these extensions

Those extensions get only installed when you run mozmill with the --debug option which is not used per default.

>  - these extensions need to be updated manually

Right, that's really annoying.

>  - these extensions should be removed manually before rolling into mozilla
> central

Well, that action will happen really rarely. Instead - I can only talk for myself - I'm using --debug really often to debug issues in a fresh profile.

> While there is convenience gained by the user in having these extensions
> available, we should find a way to provide this convenience without having
> these binary extensions replicated in our tree.

Something I would be ok with, is when I could specify a local folder which has all the add-ons I want to have for debugging. All of those should be installed. I would assume --addons works already for this.

Comment 2

[cmtalbert]

(In reply to comment #1)
> (In reply to comment #0)

> Something I would be ok with, is when I could specify a local folder which has
> all the add-ons I want to have for debugging. All of those should be installed.
> I would assume --addons works already for this.

Yes, I believe that is the entire point of --addons.

Comment 3

[Jeff Hammel]

This should go in 2.0 if its not done already

Comment 4

[Heather Arthur [:harth]]

fixed by bug 602284