If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

non-IPC builds burning with nsContentPermissionHelper

RESOLVED FIXED

Status

()

Core
DOM
--
blocker
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Bruno 'Aqualon' Escherl, Assigned: standard8)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.11 KB, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: approval2.0+
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
One of the landings from http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d668a9be7bd4&tochange=df5f653ea413 makes our tree burn, probably because we don't build IPC.

Comment 1

7 years ago
Providing the errors would be helpful.

Comment 2

7 years ago
Judging from the messages, which have us fail with nsContentPermissionHelper, this must be bug 595445 and/or bug 595456, and yes, I'm pretty sure that not having IPC enabled yet is the culprit.The bug belongs into DOM, where the failure is happening.
Component: General → DOM
Product: SeaMonkey → Core
QA Contact: general → general
Summary: SeaMonkey tree burning after some patches landed → SeaMonkey tree burning with nsContentPermissionHelper

Comment 3

7 years ago
Failure logs:

Linux:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284490532.1284491031.5612.gz

In file included from /builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.cpp:38:
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:55: error: expected class-name before ‘{’ token
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:57: error: expected ‘,’ or ‘...’ before ‘::’ token
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:57: error: ISO C++ forbids declaration of ‘IPC’ with no type
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:60: error: ISO C++ forbids declaration of ‘nsCOMPtr’ with no type
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:60: error: expected ‘;’ before ‘<’ token
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:61: error: ISO C++ forbids declaration of ‘nsCOMPtr’ with no type
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:61: error: expected ‘;’ before ‘<’ token
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:62: error: ISO C++ forbids declaration of ‘nsCOMPtr’ with no type
/builds/slave/comm-central-trunk-linux/build/mozilla/dom/base/nsContentPermissionHelper.h:62: error: expected ‘;’ before ‘<’ token
NEXT ERROR make[6]: *** [nsContentPermissionHelper.o] Error 1
Mac:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284488480.1284488776.25575.gz

In file included from /builds/slave/comm-central-trunk-linux64/build/mozilla/dom/base/nsContentPermissionHelper.cpp:38:0:
/builds/slave/comm-central-trunk-linux64/build/mozilla/dom/base/nsContentPermissionHelper.h:41:29: fatal error: base/basictypes.h: No such file or directory
compilation terminated.
make[6]: *** [nsContentPermissionHelper.o] Error 1

Windows:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284490948.1284491711.9220.gz

e:\builds\slave\comm-central-trunk-win32\build\mozilla\dom\base\nsContentPermissionHelper.h(41) : fatal error C1083: Cannot open include file: 'base/basictypes.h': No such file or directory
make[6]: *** [nsContentPermissionHelper.obj] Error 2
(Reporter)

Comment 4

7 years ago
Thunderbird has the same problems, e.g. http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1284490126.1284491352.7238.gz
Summary: SeaMonkey tree burning with nsContentPermissionHelper → non-IPC builds burning with nsContentPermissionHelper
(Assignee)

Comment 5

7 years ago
I have a fix under test for this.
Assignee: nobody → bugzilla
(Assignee)

Comment 6

7 years ago
Created attachment 475187 [details] [diff] [review]
Bustage fix

Bustage fix for non-IPC builds - just move the ifdef to encompass everything.
Attachment #475187 - Flags: review?
Attachment #475187 - Flags: approval2.0?
(Assignee)

Updated

7 years ago
Attachment #475187 - Flags: review? → review?(benjamin)

Comment 7

7 years ago
Comment on attachment 475187 [details] [diff] [review]
Bustage fix

I think that the correct fix here is to ifdef out this file in the Makefile.in, not here. This will cause build warnings about empty .o files, which may actually be a build error in some configurations.
Attachment #475187 - Flags: review?(benjamin)
Attachment #475187 - Flags: review-
Attachment #475187 - Flags: approval2.0?
(Assignee)

Comment 8

7 years ago
Created attachment 475215 [details] [diff] [review]
Bustage fix v2

Knew I should have gone with the other version... This should fix it.
Attachment #475187 - Attachment is obsolete: true
Attachment #475215 - Flags: review?(benjamin)
Attachment #475215 - Flags: approval2.0?
(Assignee)

Comment 9

7 years ago
I'm off to bed, so if this gets review and someone wants to land on my behalf, please do.

Updated

7 years ago
Attachment #475215 - Flags: review?(benjamin)
Attachment #475215 - Flags: review+
Attachment #475215 - Flags: approval2.0?
Attachment #475215 - Flags: approval2.0+
(Reporter)

Comment 10

7 years ago
(In reply to comment #8)
> Created attachment 475215 [details] [diff] [review]
> Bustage fix v2
> 
> Knew I should have gone with the other version... This should fix it.
Pushed by jdm as http://hg.mozilla.org/mozilla-central/rev/53a5148e8fad

00:08 < firebot> Thunderbird: 'WINNT 5.2 comm-central build' has changed state from Burning to Success.

-> Resolved Fixed
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.