Closed Bug 596329 Opened 9 years ago Closed 9 years ago

Disable "Save as PDF" menu item on platforms where it doesn't work

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
NS_PRINTING is disabled on Android and "Save As PDF" is broken, because and we don't have implementations of the necessary services (Bug 595919).

Until it is working, we should probably hide the menu item.
Attachment #475167 - Flags: review?(mark.finkle)
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
We'll need to construct testcases for this.  matt, can you list out a few examples of platforms where this would be hidden?
Flags: in-litmus?
(In reply to comment #1)
> We'll need to construct testcases for this.  matt, can you list out a few
> examples of platforms where this would be hidden?

Android: hidden (until bug 595919 is fixed)

all other platforms: not hidden
Comment on attachment 475167 [details] [diff] [review]
patch

This might be a bit overkill. Hiding the button is one thing, removing all the code is another. Especially if we plan on fixing this ASAP.

Feel free to just hide the action, by hidning the XUL and stopping the register from happening. If you want the whole patch, that's fine, but let's remember to undo the preprocessor stuff when we fix this. I'd rather not have preprocessor directives in the FE code if possible.
Attachment #475167 - Flags: review?(mark.finkle) → review+
Toned down and pushed, using a minimal amount of preprocessor: http://hg.mozilla.org/mobile-browser/rev/4e90444031e5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: mbrubeck → ayanshah62
Assignee: ayanshah62 → mbrubeck
Flags: in-litmus? → in-litmus?(ayanshah62)
Verified on :

Build: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b7pre)Gecko/20100928
Firefox/4.0b7pre Fennec /2.0b1pre

and 

Build: Mozilla /5.0 (Maemo;Linux armv7l;rv:2.0b7pre)Gecko/20100928
Firefox/4.0b7pre Fennec /2.0b1pre
Status: RESOLVED → VERIFIED
Litmus test case added:

https://litmus.mozilla.org/show_test.cgi?id=13531
Flags: in-litmus?(ayanshah62) → in-litmus+
Note to tester: Bug 595919 is the fix for this bug. So when that bug is fixed, this test case will have to be disabled.
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.