596377 - IndexedDB: Move usage and clearing IO off the main thread

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Currently clearing the databases for an origin or getting the total usage for an origin perform all IO on the main thread. Attached patch moves everything off to another thread and makes everything asynchronous without pumping the event loop.

Comment 1

[Johnny Stenback (:jst)]

We want this for betaN.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 475239 [details] [diff] [review]
Patch, v1

All functions, classes, and class members that are declared in headerfiles needs documentation for what they do and what their arguments mean. Also what they return.

>+#define DEFAULT_THREAD_TIMEOUT_MS 30000
>+#define DEFAULT_SHUTDOWN_TIMER_MS 30000

Add comments!

>+IndexedDatabaseManager::FactoryCreate()
> {
>-  return gInstance;
>+  // Returns a raw pointer that carries an owning reference! Lame, but the
>+  // singleton factory macros force this.
>+  nsRefPtr<IndexedDatabaseManager> instance(GetOrCreate());
>+  IndexedDatabaseManager* rawInstance;
>+  instance.forget(&rawInstance);
>+  return rawInstance;
> }

return GetOrCreate().get();

>+IndexedDatabaseManager::CancelGetUsageForURI(
...
>+    if (equals) {
>+      nsCOMPtr<nsISupports> ident1(do_QueryInterface(aCallback));
>+      nsCOMPtr<nsISupports> ident2(do_QueryInterface(runnable->mCallback));
>+      if (ident1 == ident2) {
>+        runnable->Cancel();
>+        break;

Use SameCOMIdentity

>+IndexedDatabaseManager::OriginClearRunnable::OnDatabaseComplete(
>+  if (mDatabasesWaiting.IsEmpty()) {
>+    if (NS_FAILED(mThread->Dispatch(this, NS_DISPATCH_NORMAL))) {
>+      NS_WARNING("Can't dispatch to IO thread!");
>+    }
>+    mThread = nsnull;
>+  }

Add a comment stating what this section does. I.e. that we're dispatching to the thread to do the file ops.


>+NS_IMETHODIMP
>+IndexedDatabaseManager::OriginClearRunnable::Run()
>+{
>+  NS_ASSERTION(!mThread, "Should have been cleared already!");
>+
>+  if (NS_IsMainThread()) {

Nit: I'd reverse this since this since the main-thread code is run after the other code. But up to you.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/6476d61a80d5