596477 - Some users' pics still missing after running ./manage.py fix_user_images on prod

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Even after we ran ./manage.py fix_user_images in today's push to fix user-profile pics over in bug 593267, we're still seeing some users (Wil estimates ~15%) missing their pics, such as our own fligtar:

https://addons.mozilla.org/en-US/firefox/user/9945/

Comment 1

[Wil Clouser [:clouserw]]

http://github.com/clouserw/zamboni/commit/feb8b315ee0b95fb42fe96fd27cf4ab7f9d7ad24

boom.  also, r?

Comment 2

[Wil Clouser [:clouserw]]

Alright, this is committed and it runs great on my dev copy, but doesn't seem to queue tasks on preview.  Can someone try running this on their dev copy?

0) make sure you have at least 1 image under your USERPICS_PATH.  /0/10/10482.png is fine (you can just touch the file, doesn't have to be an image).  

1) `UPDATE users SET picture_type='' WHERE id=10482`

2) Run `./manage.py fix_user_images_again`.  You'll need celeryd running.

3) SELECT picture_type from users where id=10482

4) If all went well, step 3 will show 'image/png'

Comment 3

[Wil Clouser [:clouserw]]

Fixed.  https://preview.addons.mozilla.org/en-US/firefox/user/9945/

Wasn't working on preview because the last time we imported all the user pics they weren't pngs yet.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks.