596489 - Support permanent device loss with D3D9

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

We should support the device we're currently using permanently being removed somehow (crashes, reinstall, disable, etc.) with the D3D9 layers backend.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Part 1: Expose when a DeviceManager's device is removed

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Part 2: Refactor DeviceManager ownership

This is needed to allow a different DeviceManager to become the default as LayerManagers die and let go of the DeviceManager's they were using.

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Part 3: Destroy current layer manager and invalidate upon device removal

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 475424 [details] [diff] [review]
Part 2: Refactor DeviceManager ownership

>+  mWidget = aWidget;
>+  mCurrentCallbackInfo.Callback = NULL;
>+  mCurrentCallbackInfo.CallbackData = NULL;
>+
>+  if (mDeviceManager && mDeviceManager->Release() == 0) {
>+    mDeviceManager = nsnull;
>+  }

Oops.

>diff --git a/gfx/layers/d3d9/LayerManagerD3D9.h b/gfx/layers/d3d9/LayerManagerD3D9.h
>--- a/gfx/layers/d3d9/LayerManagerD3D9.h
>+++ b/gfx/layers/d3d9/LayerManagerD3D9.h
>   static void OnDeviceManagerDestroy(DeviceManagerD3D9 *aDeviceManager) {
>-    if(aDeviceManager == mDeviceManager)
>-      mDeviceManager = nsnull;
>+    if(aDeviceManager == mDefaultDeviceManager)

missing space after "if ("

Comment 5

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/7a05dd5b25de
http://hg.mozilla.org/mozilla-central/rev/c5608e9f3753
http://hg.mozilla.org/mozilla-central/rev/7cf62a2a821e

Comment 6

[Joe Drew (not getting mail)]

Crap, sorry, wrong revisions in the above comment. These are the correct revisions:

http://hg.mozilla.org/mozilla-central/rev/a38c033e298b
http://hg.mozilla.org/mozilla-central/rev/70e0e08ed6dd
http://hg.mozilla.org/mozilla-central/rev/20f4616058da